Skip to content

Move programming with rcl and rclc before advanced tutorials.#339

Merged
ralph-lange merged 5 commits into
masterfrom
move_order_of_tutorials
Sep 13, 2021
Merged

Move programming with rcl and rclc before advanced tutorials.#339
ralph-lange merged 5 commits into
masterfrom
move_order_of_tutorials

Conversation

@ralph-lange

Copy link
Copy Markdown
Contributor

@pablogs9, @JanStaschulat: I've also added distro status badges to the individual programming with rcl and rclc tutorials. Please check whether they are correct!

…tutorials.

Signed-off-by: Ralph Lange <ralph.lange@de.bosch.com>
… rclc tutorials.

Signed-off-by: Ralph Lange <ralph.lange@de.bosch.com>
pablogs9
pablogs9 previously approved these changes Sep 10, 2021

@pablogs9 pablogs9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check CI

Signed-off-by: Ralph Lange <ralph.lange@de.bosch.com>
@ralph-lange

Copy link
Copy Markdown
Contributor Author

Hi @pablogs9, I've fixed all links from the previous PR. Any idea for the reason of the last remaining build error?

@pablogs9

Copy link
Copy Markdown
Member

Lets see if is related to this PR or is an error in master: #340

@pablogs9

Copy link
Copy Markdown
Member

Not related to this PR. @Acuadros95 can you take a look on this error?

@pablogs9 pablogs9 requested a review from Acuadros95 September 10, 2021 11:23
@Acuadros95

Copy link
Copy Markdown
Contributor

The Cleaning up section of the parameters tutorial was inside a misformatted code block, caused by missing indentation in the previous section.

My last commit should fix it.

@pablogs9

Copy link
Copy Markdown
Member

Thanks a lot!

@ralph-lange

Copy link
Copy Markdown
Contributor Author

Thank you very much, @Acuadros95

@ralph-lange ralph-lange merged commit c0ae84a into master Sep 13, 2021
@ralph-lange ralph-lange deleted the move_order_of_tutorials branch September 13, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants